-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: explain express in crafting loopback 4 #1630
Conversation
docs/site/Crafting-LoopBack-4.md
Outdated
In contrast, LoopBack is designed to facilitate API creation and composition | ||
by conventions and patterns as best practices. More types of constructs are | ||
introduced. | ||
### Why Express Still? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to have Why Express behind the scene?
docs/site/Crafting-LoopBack-4.md
Outdated
#### Circling back to Express with a twist | ||
|
||
LoopBack does a lot of things but our value add is the ease of use and data | ||
processing, not middleware and routing so we didn't want to reinvent the wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Routing is the part we want to optimize based on controller metadata. As a result, we minimize the usage of Express routing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docs/site/Crafting-LoopBack-4.md
Outdated
|
||
#### Circling back to Express with a twist | ||
|
||
LoopBack does a lot of things but our value add is the ease of use and data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean by but our value add is ...
docs/site/Crafting-LoopBack-4.md
Outdated
only for their middleware support). The final decision was to use Express in a | ||
way that bridges the gap by addressing the gaps identified above as follows: | ||
|
||
- LoopBack provides it's own |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's -> its
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
7876395
to
c404f72
Compare
c404f72
to
a42898f
Compare
fixes #1538
Checklist
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated